Re: [PATCH v8 06/11] clk: renesas: rzg2l-cpg: Re-enable critical module clocks during resume

[Geert Uytterhoeven]

On Tue, 24 Mar 2026 at 12:43, Biju <biju.das.au@xxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> After a suspend/resume cycle, critical module clocks (CLK_IS_CRITICAL) may
> be left disabled as there is no owning driver to restore them, unlike
> regular clocks.
> Add rzg2l_mod_enable_crit_clock_init_mstop() which walks all module clocks
> on resume, re-enables any critical clock found disabled, and then restores
> the MSTOP state for clocks that have one via the existing helper. This
> replaces the direct call to rzg2l_mod_clock_init_mstop() in
> rzg2l_cpg_resume(), preserving the correct clock-before-MSTOP restore
> ordering.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v7->v8:
>  * Updated comment in rzg2l_mod_clock_init_mstop_helper() as resume()
>    calls this function.
>  * To avoid setting module state twice and also not to update the initial
>    mstop state for the critical clocks state during probe, replaced
>    rzg2l_mod_clock_endisable()->rzg2l_mod_clock_endisable_helper().

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-clk for v7.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds