Re: [PATCH v4] staging: media: atomisp: pci: fix split GP_TIMER_BASE declaration

From: Andy Shevchenko

Date: Thu Mar 26 2026 - 07:02:42 EST


On Wed, Mar 25, 2026 at 06:54:34PM +0530, Anushka Badhe wrote:
> Merge declaration of const GP_TIMER_BASE split across 2 lines to improve
> readability.

Nice, but this constant is only used in one file, id est gp_timer.c.
Just move it there with the (fixed style of the) comment to there
and drop the mentioning in the rest of the files. With this being done,
the patch gains real value.

--
With Best Regards,
Andy Shevchenko