Re: [PATCH 4/4] arm64: tegra: add e2426-1099+e2423-1099 support

[Krzysztof Kozlowski]

On Wed, Mar 25, 2026 at 09:26:28PM +0000, Chun Ng wrote:
> Add the Tegra238 SoC device tree (tegra238.dtsi) and a minimal device
> tree for the Tegra238 E2426-1099+E2423-1099 engineering reference
> platform. The device-tree is not yet bootable and further enablement

Then drop it. If this cannot be booted then it is pointless in the
kernel, no benefit, no one can ever use it.

> will be added in follow-up patches.
> 
> Signed-off-by: Chun Ng <chunn@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/nvidia/Makefile           |   2 +
>  .../nvidia/tegra238-e2426-1099+e2423-1099.dts |  16 ++
>  arch/arm64/boot/dts/nvidia/tegra238.dtsi      | 190 ++++++++++++++++++
>  3 files changed, 208 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra238-e2426-1099+e2423-1099.dts
>  create mode 100644 arch/arm64/boot/dts/nvidia/tegra238.dtsi
> 
> diff --git a/arch/arm64/boot/dts/nvidia/Makefile b/arch/arm64/boot/dts/nvidia/Makefile
> index b139cbd14442..a5357809e222 100644
> --- a/arch/arm64/boot/dts/nvidia/Makefile
> +++ b/arch/arm64/boot/dts/nvidia/Makefile
> @@ -13,6 +13,7 @@ DTC_FLAGS_tegra234-p3737-0000+p3701-0000 := -@
>  DTC_FLAGS_tegra234-p3740-0002+p3701-0008 := -@
>  DTC_FLAGS_tegra234-p3768-0000+p3767-0000 := -@
>  DTC_FLAGS_tegra234-p3768-0000+p3767-0005 := -@
> +DTC_FLAGS_tegra238-e2426-1099+e2423-1099 := -@
>  DTC_FLAGS_tegra264-p3971-0089+p3834-0008 := -@
>  
>  dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb
> @@ -34,4 +35,5 @@ dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3737-0000+p3701-0008.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3740-0002+p3701-0008.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3768-0000+p3767-0000.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_234_SOC) += tegra234-p3768-0000+p3767-0005.dtb
> +dtb-$(CONFIG_ARCH_TEGRA_238_SOC) += tegra238-e2426-1099+e2423-1099.dtb
>  dtb-$(CONFIG_ARCH_TEGRA_264_SOC) += tegra264-p3971-0089+p3834-0008.dtb
> diff --git a/arch/arm64/boot/dts/nvidia/tegra238-e2426-1099+e2423-1099.dts b/arch/arm64/boot/dts/nvidia/tegra238-e2426-1099+e2423-1099.dts
> new file mode 100644
> index 000000000000..d69ea2114e23
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nvidia/tegra238-e2426-1099+e2423-1099.dts
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +/dts-v1/;
> +
> +#include "tegra238.dtsi"
> +
> +/ {
> +	model = "NVIDIA Tegra238 E2426-1099+E2423-1099";
> +	compatible = "nvidia,e2426-1099+e2423-1099", "nvidia,tegra238";
> +
> +	bus@0 {
> +		uarta: serial@3100000 {
> +			status = "okay";
> +		};
> +	};
> +};
> diff --git a/arch/arm64/boot/dts/nvidia/tegra238.dtsi b/arch/arm64/boot/dts/nvidia/tegra238.dtsi
> new file mode 100644
> index 000000000000..0570c3b20e62
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nvidia/tegra238.dtsi
> @@ -0,0 +1,190 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#include <dt-bindings/clock/nvidia,tegra238.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/mailbox/tegra186-hsp.h>
> +#include <dt-bindings/reset/nvidia,tegra238.h>
> +
> +/ {
> +	compatible = "nvidia,tegra238";
> +	interrupt-parent = <&gic>;
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	bus@0 {
> +		compatible = "simple-bus";
> +
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x0 0x0 0x0 0x0 0x0 0x80000000>;
> +
> +		uarta: serial@3100000 {
> +			compatible = "arm,pl011", "arm,primecell";
> +			reg = <0x0 0x3100000 0x0 0x10000>;
> +			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&bpmp TEGRA238_CLK_UARTA>,
> +				 <&bpmp TEGRA238_CLK_PLLP_OUT0>;
> +			clock-names = "uartclk", "apb_pclk";
> +			assigned-clocks = <&bpmp TEGRA238_CLK_UARTA>;
> +			assigned-clock-parents = <&bpmp TEGRA238_CLK_PLLP_OUT0>;
> +			resets = <&bpmp TEGRA238_RESET_UARTA>;
> +			arm,primecell-periphid = <0x00051011>;
> +			status = "disabled";
> +		};
> +
> +		fuse@3810000 {
> +			compatible = "nvidia,tegra234-efuse";
> +			reg = <0x0 0x03810000 0x0 0x19000>;
> +			clocks = <&bpmp TEGRA238_CLK_FUSE>;
> +			clock-names = "fuse";
> +		};
> +
> +		hsp_top0: tegra-hsp@3c00000 {
> +			compatible = "nvidia,tegra234-hsp", "nvidia,tegra194-hsp";

DTSI says 238, compatible says 234.

Best regards,
Krzysztof