Re: [PATCH 4/8] drm/bridge: dw-hdmi: document the output_port field

[Liu Ying]

Hi Luca,

On Fri, Mar 20, 2026 at 11:46:15AM +0100, Luca Ceresoli wrote:
> The meaning of this flag may not be obvious at first sight.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
> ---
>  include/drm/bridge/dw_hdmi.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/drm/bridge/dw_hdmi.h b/include/drm/bridge/dw_hdmi.h
> index 336f062e1f9d..45f6ba1a8ee1 100644
> --- a/include/drm/bridge/dw_hdmi.h
> +++ b/include/drm/bridge/dw_hdmi.h
> @@ -126,6 +126,11 @@ struct dw_hdmi_phy_ops {
>  struct dw_hdmi_plat_data {
>  	struct regmap *regm;
>  
> +	/*
> +	 * The HDMI output port number (which must be 1) if it is described

I'd rephrase:
The HDMI output port number must be 1 ...

> +	 * in the device tree. 0 if the device tree does not describe the
> +	 * next component (legacy mode).

Maybe be a bit more specific about "legacy mode":
legacy mode without DRM_BRIDGE_ATTACH_NO_CONNECTOR flag when attaching bridge
?

Reviewed-by: Liu Ying <victor.liu@xxxxxxx>

> +	 */
>  	unsigned int output_port;
>  
>  	unsigned long input_bus_encoding;
> 

-- 
Regards,
Liu Ying