Re: [PATCH 0/2] uaccess: unify inline vs outline copy_{from,to}_user() selection
From: Andrew Morton
Date: Wed Mar 25 2026 - 19:33:35 EST
On Wed, 25 Mar 2026 12:33:10 -0400 Yury Norov <ynorov@xxxxxxxxxx> wrote:
> Christophe has pointed in [1] that one my patch incorrectly defines
> rust_helper__copy_to_user() wrapper based on INLINE_COPY_FROM_USER.
>
> Having separate controls for 'from' and 'to' versions is pretty useless,
> and has proven to be error prone. So, instead of fixing the rust portion,
> simply switch the kernel to a single knob.
>
> [1] https://lore.kernel.org/all/746c9c50-20c4-4dc9-a539-bf1310ff9414@xxxxxxxxxx/
Some changelog whining:
As this series is aimed at mainline inclusion, I don't see much value
in changelogging which refers to previous development versions of the
patchset. That's useful material to include below the ^---$ separator,
but it isn't of interest to our target audience: people who are reading
this patchset three years hence.
So can we please have a clean description of what this patchset does and
why it does it?
Also, [1/2] says
Fixes: 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST")
but I'm not actually seeing a description of what was wrong with
1f9a8286bc0c. Can we please have a description of the motivation in
here somewhere?