Re: [PATCH mm-new v8 2/4] mm: khugepaged: refine scan progress number
From: Andrew Morton
Date: Wed Mar 25 2026 - 15:16:26 EST
On Wed, 25 Mar 2026 18:53:40 +0000 "Lorenzo Stoakes (Oracle)" <ljs@xxxxxxxxxx> wrote:
> > [akpm@xxxxxxxxxxxxxxxxxxxx: fix spello, add comment]
> > Link: https://lkml.kernel.org/r/20260220151500.13585-1-rioo.tsukatsukii@xxxxxxxxx
> > Signed-off-by: Rio <rioo.tsukatsukii@xxxxxxxxx>
> > Cc: Joel Granados <joel.granados@xxxxxxxxxx>
> > Cc: Petr Mladek <pmladek@xxxxxxxx>
> > Cc: Wang Jinchao <wangjinchao600@xxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >
> > But these things are usually quite minor and the precipitating
> > discussion can be found by reading the main Link:.
> >
> > > Maybe just directly squash the commits?
> >
> > Not understanding this proposal?
>
> I mean instead of having a separate commit for the fix, put that fix into the
> patch before it and denote it with a footer as you put above.
>
> I guess that translates to what you do when you rebase and fold the fixes into
> commits as you do now anyway.
>
> I don't see any reason not to do that right away, as really it's good to see the
> combined change in one go for all practical purposes (if I resend, I'll be
> combining work, if I can grab it from the tree and avoid a git rebase -i all the
> better).
OK. So what have we concluded here?
Is it: if I get a -fix, I add that in the usual way, then temporarily
fold it into the base patch and mail the result out for fyi. Then
after <period> I permanently fold the fix into the base and add the
footer?
If so, what's <period>?