Re: [PATCH] netfs: Fix the handling of stream->front by removing it

[Paulo Alcantara]

David Howells <dhowells@xxxxxxxxxx> writes:

> The netfs_io_stream::front member is meant to point to the subrequest
> currently being collected on a stream, but it isn't actually used this way
> by direct write (which mostly ignores it).  However, there's a tracepoint
> which looks at it.  Further, stream->front is actually redundant with
> stream->subrequests.next.
>
> Fix the potential problem in the direct code by just removing the member
> and using stream->subrequests.next instead, thereby also simplifying the
> code.
>
> Fixes: a0b4c7a49137 ("netfs: Fix unbuffered/DIO writes to dispatch subrequests in strict sequence")
> Reported-by: Paulo Alcantara <pc@xxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: netfs@xxxxxxxxxxxxxxx
> cc: linux-fsdevel@xxxxxxxxxxxxxxx
> ---
>  fs/netfs/buffered_read.c     |    3 +--
>  fs/netfs/direct_read.c       |    3 +--
>  fs/netfs/direct_write.c      |    1 -
>  fs/netfs/read_collect.c      |    4 ++--
>  fs/netfs/read_single.c       |    1 -
>  fs/netfs/write_collect.c     |    4 ++--
>  fs/netfs/write_issue.c       |    3 +--
>  include/linux/netfs.h        |    1 -
>  include/trace/events/netfs.h |    8 ++++----
>  9 files changed, 11 insertions(+), 17 deletions(-)

Reviewed-by: Paulo Alcantara (Red Hat) <pc@xxxxxxxxxxxxx>