Re: [PATCH v3 2/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_clock_recovery_ok()
From: Luca Ceresoli
Date: Wed Mar 25 2026 - 08:48:03 EST
On Mon Nov 10, 2025 at 9:58 AM CET, Damon Ding wrote:
> Use existing DP helper API instead of analogix_dp_clock_recovery_ok()
> with the same function.
>
> Signed-off-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx>
> Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> @@ -398,7 +385,7 @@ static int analogix_dp_process_clock_recovery(struct analogix_dp_device *dp)
> if (retval < 0)
> return retval;
>
> - if (analogix_dp_clock_recovery_ok(link_status, lane_count) == 0) {
> + if (drm_dp_clock_recovery_ok(link_status, lane_count)) {
It took a while to realize that drm_dp_clock_recovery_ok() really does the
same thing as analogix_dp_clock_recovery_ok(), but it looks fine.
Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com