Re: [PATCH] dt-bindings: reset: st: convert to dtschema

[Gopi Krishna Menon]

On Wed, Mar 25, 2026 at 12:39:36PM +0100, Krzysztof Kozlowski wrote:

> On Tue, Mar 24, 2026 at 09:29:30PM +0530, Gopi Krishna Menon wrote:
> > Convert the STiH4xx reset controller bindings to DT schema.
> > 
> > Suggested-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> > Suggested-by: Dhruva Gole <d-gole@xxxxxx>
> 
> Both suggested you to write this patch?
> 
Hi Krzysztof,

Thanks for the review, They helped me to improve the PATCH,

- Dhruva suggested me to change the subject from dt-bindings: power:
  reset: st: convert to dtschema to dt-bindings: reset: st: convert to
  dtschema as that was the general trend followed with similar files.
- Daniel suggested me to use the word 'reset' instead of 'restart' in
  the patch (whereever possible) as that is more accurate here.

That's why I added those Suggested-by tags.

> > Signed-off-by: Gopi Krishna Menon <krishnagopi487@xxxxxxxxx>
> > ---
> > Note:
> > * This patch is part of the GSoC2026 application process for device tree bindings conversions
> > * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> > 
> >  .../power/reset/st,stih407-restart.yaml       | 31 +++++++++++++++++++
> >  .../bindings/power/reset/st-reset.txt         | 11 -------
> >  2 files changed, 31 insertions(+), 11 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/power/reset/st-reset.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> > new file mode 100644
> > index 000000000000..d7adbc00f5c3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/st,stih407-restart.yaml
> > @@ -0,0 +1,31 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/reset/st,stih407-restart.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ST SW reset controller
> > +
> > +maintainers:
> > +  - Lee Jones <lee@xxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: st,stih407-restart
> > +
> > +  st,syscfg:
> > +    description: phandle of the syscfg node
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > +required:
> > +  - compatible
> > +  - st,syscfg
> > +
> > +unevaluatedProperties: false
> 
> additionalProperties instead
> 
Ok will send a V2 for this.
> 
> Best regards,
> Krzysztof
> 
Thanks,
Gopi Krishna Menon