Re: [PATCH 2/2] spi: spi-mtk-nor: add new clock support

From: Krzysztof Kozlowski

Date: Wed Mar 25 2026 - 07:59:43 EST


On Wed, Mar 25, 2026 at 11:18:55AM +0800, Meiker Gao wrote:
> one more clock gate need to be added.

Your patch removes clock, not adds. Write useful commit msgs, because
this is completely useless one.

...

> @@ -828,13 +839,17 @@ static int mtk_nor_probe(struct platform_device *pdev)
> if (IS_ERR(ctlr_clk))
> return PTR_ERR(ctlr_clk);
>
> - axi_clk = devm_clk_get_optional(&pdev->dev, "axi");

NAK, ABI break. Read guides about writing bindings.

Best regards,
Krzysztof