Re: [PATCH v7 07/31] gpu: nova-core: move firmware image parsing code to firmware.rs
From: Miguel Ojeda
Date: Wed Mar 25 2026 - 07:26:06 EST
On Wed, Mar 25, 2026 at 12:06 PM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>
> No, you are correct; removing them works fine with the latest Rust, so I
> assumed they were unneeded - but 1.78 fails to build without them.
So that wouldn't work in general, but it happens that for `size_of`
and friends were added to the standard library prelude in 1.80.0.
So I added those to our own prelude so that 1.78 would work too if one
imports our prelude to minimize confusion:
72b04a8af7fb ("rust: prelude: re-export `core::mem::{align,size}_of{,_val}`")
I hope that clarifies!
Cheers,
Miguel