Re: [PATCH] dt-bindings: i2c: intel,ixp4xx-i2c: Convert to Dt schema

[Krzysztof Kozlowski]

On Tue, Mar 24, 2026 at 07:20:10PM +0530, Shi Hao wrote:
> Convert IOP3xx and IXP4xx XScale bindings to DT schema.
> 
> Signed-off-by: Shi Hao <i.shihao.999@xxxxxxxxx>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> ---
> Note:
> * This patch is part of the GSoC2026 application process for device tree bindings conversions
> * https://github.com/LinuxFoundationGSoC/ProjectIdeas/wiki/GSoC-2026-Device-Tree-Bindings
> ---

...

> diff --git a/Documentation/devicetree/bindings/i2c/intel,ixp4xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/intel,ixp4xx-i2c.yaml
> new file mode 100644
> index 000000000000..13ba2a0e336e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/intel,ixp4xx-i2c.yaml
> @@ -0,0 +1,41 @@
> +# SPDX License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i2c/intel,ixp4xx-i2c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: I2c Controller on XScale platforms such as IOP3xx and IXP4xx
> +
> +maintainers:
> +  - Andi Shyti <andi.shyti@xxxxxxxxxx>
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - intel,ixp4xx-i2c
> +      - intel,iop3xx-i2c

Alphabetical order. Dunno why you reversed it from original binding.


> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1

This wasn't in the original binding.

What does my guideline/expectations for GSoC say? Did you read it?

Best regards,
Krzysztof