Re: [PATCH v4 6/6] arm64: dts: qcom: Add AYN Thor

From: Konrad Dybcio

Date: Wed Mar 25 2026 - 07:12:58 EST


On 3/23/26 5:27 PM, Aaron Kling via B4 Relay wrote:
> From: Teguh Sobirin <teguh@xxxxxxxx>
>
> The AYN Thor is a high-performance Android-based handheld gaming console
> powered by the Qualcomm Snapdragon 8 Gen 2 processor featuring dual
> AMOLED touchscreens.
>
> Signed-off-by: Teguh Sobirin <teguh@xxxxxxxx>
> Co-developed-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> Signed-off-by: Aaron Kling <webgeek1234@xxxxxxxxx>
> ---

[...]

> +&{/} {
> + model = "AYN Thor";
> + compatible = "ayntec,thor", "qcom,qcs8550", "qcom,sm8550";
> +
> + gpio-keys {

Please override gpio-keys from common by label reference

[...]

> +&mdss_dsi0_phy {
> + vdds-supply = <&vreg_l1e_0p88>;
> + status = "okay";

nit: Please uniformly keep a \n before status

> +};
> +
> +&mdss_dsi1_out {
> + qcom,te-source = "mdp_vsync_s";
> +};
> +
> +&pm8550_pwm {
> + multi-led {
> + status = "disabled";
> + };

Please override the multi-led node by label directly

Konrad