Re: [PATCH 12/12] arm64: defconfig: Enable I3C and SPD5118 hwmon

[Krzysztof Kozlowski]

On 25/03/2026 11:31, Thierry Reding wrote:
> On Thu, Mar 19, 2026 at 06:15:14PM +0100, Krzysztof Kozlowski wrote:
>> On 19/03/2026 18:09, Akhil R wrote:
>>> On Thu, 19 Mar 2026 10:40:34 +0100, Krzysztof Kozlowski wrote:
>>>> On Wed, Mar 18, 2026 at 10:57:25PM +0530, Akhil R wrote:
>>>>> Add I3C subsystem support, DesignWare I3C master controller, and
>>>>> SPD5118 hwmon sensor as modules to the defconfig.
>>>>
>>>> Why? If there is no user of that, why would we want it? Your commit msg
>>>> should explain that.
>>>
>>> Ack. This is for Tegra410 which has a DesignWare I3C host controller.
>>> I will add this in the commit message.
>>
>> Board or products. Not SoCs.
> 
> Is this a new requirement? I see a bit of both in defconfig changes.

Almost every review from me has it for 2-3 years... And it is a known
thing since always in a bit different wording: we do not care about
downstream things and downstream products. defconfig does not serve
downstream at all, makes no sense outside of our (upstream) work.

> Some mention specific products, other mention SoCs. Does this
> requirement apply to DT platforms or also ACPI platforms?

Just like kernel, applies to all platforms, regardless of firmware
interface.

Best regards,
Krzysztof