Re: [PATCH v7 1/2] dt-bindings: iio: proximity: add ST VL53L1X ToF sensor
From: Krzysztof Kozlowski
Date: Wed Mar 25 2026 - 05:00:30 EST
On 25/03/2026 09:48, Sirat wrote:
> On Wed, Mar 25, 2026 at 2:05 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On Wed, Mar 25, 2026 at 12:32:22PM +0600, Siratul Islam wrote:
>>> Add device tree binding documentation for the STMicroelectronics
>>> VL53L1X Time-of-Flight ranging sensor connected via I2C.
>>>
>>> Make vdd-supply required. The device requires power to operate
>>> and the property should have been required from the start.
>>
>> That's ABI break and device for many years was working fine, so this
>> should not be changed.
>>
> Jonathan and David asked that vdd-supply be made required. I feel like
> there is a conflict here that I am not able to resolve myself.
>
> What I think about it is the binding does not correctly describe the
> hardware and we should consider this a bug and fix it.
> The driver worked because of a fallback mechanism (dummy/fake
> regulator) and not because power was optional.
>
I looked at v6 and v5 and I do not see such comment for binding that
existing device should change ABI. Can you point me to it?
Best regards,
Krzysztof