Re: [PATCH v4] mm/userfaultfd: fix hugetlb fault mutex hash calculation

[David Hildenbrand (Arm)]

On 3/25/26 07:07, Jianhui Zhou wrote:
> On Tue, Mar 25, 2026 at 01:06:00AM +0000, SeongJae Park wrote:
>> Seems userfaulfd.c is the only caller of the new helper function.  Why don't
>> you define the function in userfaultfd.c ?
> I kept hugetlb_linear_page_index() in include/linux/hugetlb.h because
> this is hugetlb-specific logic, not userfaultfd-specific logic.

Yes, and see my comment about either removing it entirely again next, or
actually also using it in hugetlb.c.

-- 
Cheers,

David