Re: [PATCH] perf symbols: Add 'intel_idle_irq' to the list of idle symbols

[Namhyung Kim]

On Mon, Mar 23, 2026 at 11:35:05AM -0700, Ian Rogers wrote:
> On Mon, Mar 23, 2026 at 1:53 AM Honglei Wang <jameshongleiwang@xxxxxxx> wrote:
> >
> > Commit 32d4fd5751ea ("cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE")
> > introduced intel_idle_irq as entry of those with
> > CPUIDLE_FLAG_IRQ_ENABLE, say, skx and icx so far. Let's add a new
> > one to the list of idle symbols to avoid noise.
> >
> > Signed-off-by: Honglei Wang <jameshongleiwang@xxxxxxx>
> > ---
> >  tools/perf/util/symbol.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> > index 8662001e1e25..7cff66e7ce06 100644
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -730,6 +730,7 @@ static bool symbol__is_idle(const char *name)
> >                 "cpu_startup_entry",
> >                 "idle_cpu",
> >                 "intel_idle",
> > +               "intel_idle_irq",
> 
> It would be nice to make this an Intel specific idle symbol. I sent
> out a patch set to do this:
> https://lore.kernel.org/lkml/20260302234343.564937-1-irogers@xxxxxxxxxx/
> but there are no reviews. Perhaps we can follow up that patch by
> adding this symbol. Arnaldo, Namhyung, wdyt? I believe Arnaldo was
> supportive in:
> https://lore.kernel.org/lkml/aahC-zp56irr5e2k@x1/

Yeah, I'm ok in general.  I've left a comment there.

Thanks,
Namhyung