Re: [PATCH 3/3] mm: memcontrol: correct the nr_pages parameter type of mem_cgroup_update_lru_size()
From: Harry Yoo (Oracle)
Date: Tue Mar 24 2026 - 20:27:10 EST
On Tue, Mar 24, 2026 at 12:28:08PM +0000, Lorenzo Stoakes (Oracle) wrote:
> On Tue, Mar 24, 2026 at 07:31:29PM +0800, Qi Zheng wrote:
> > From: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> >
> > The nr_pages parameter of mem_cgroup_update_lru_size() should clearly
> > be long instead of int, let's correct it.
>
> Hmm, but are you ever going to be adding that many pages? I guess technically
> correct though.
It has been fine as-is, but reparenting changes that.
Reparenting in theory could add billions of pages at once!
And yeah the commit message could be improved.
--
Cheers,
Harry / Hyeonggon