Re: [PATCH bpf-next v2] bpf: Simplify tnum_step()
From: Alexei Starovoitov
Date: Tue Mar 24 2026 - 17:37:01 EST
On Tue, Mar 24, 2026 at 2:33 PM Harishankar Vishwanathan
<harishankar.vishwanathan@xxxxxxxxx> wrote:
>
> On Tue, Mar 24, 2026 at 11:50 AM <patchwork-bot+netdevbpf@xxxxxxxxxx> wrote:
> >
> > Hello:
> >
> > This patch was applied to bpf/bpf-next.git (master)
> > by Alexei Starovoitov <ast@xxxxxxxxxx>:
>
> Hello, I see this was applied. Just a heads up that I still had a few
> concerns regarding the
> commit message and code style in my last reply. I think it was my
> mistake to include
> the Reviewed-by while still requesting changes.
>
> Hao, would you like to send a follow-up for those, or should I put one together?
>
> Or Alexei, do you think it is okay as is? If yes, we can just leave it be.
They read like nits to me.
New code is definitely cleaner.
As a follow up better craft a targeted selftest and explain
your points in selftest comments.