Re: [PATCH v1 2/6] spi: spi-qcom-qspi: Add interconnect support for memory path

From: Mark Brown

Date: Tue Mar 24 2026 - 12:38:52 EST


On Tue, Mar 24, 2026 at 06:43:19PM +0530, Viken Dadhaniya wrote:

> @@ -829,6 +842,13 @@ static int __maybe_unused qcom_qspi_runtime_suspend(struct device *dev)
> return ret;
> }
>
> + ret = icc_disable(ctrl->icc_path_mem);
> + if (ret) {
> + dev_err_ratelimited(ctrl->dev, "ICC disable failed for memory: %d\n", ret);
> + icc_enable(ctrl->icc_path_cpu_to_qspi);
> + return ret;
> + }
> +

This reenables the ICC but not the clocks on error (which is a
preexisting bug with the error handling if the other ICC fails but
still...).

Attachment: signature.asc
Description: PGP signature