Re: [PATCH v4 1/3] cxl/core/region: move pmem region driver logic into region_pmem.c

From: Gregory Price

Date: Tue Mar 24 2026 - 11:12:26 EST


On Mon, Mar 23, 2026 at 08:49:02PM -0700, Alison Schofield wrote:
> On Mon, Mar 23, 2026 at 01:37:49AM -0400, Gregory Price wrote:
> >
> > The recent pmem/nvdimm Kconfig change does kind of show that we might
> > have some bloat for some deployments which might not care about pmem -
> > for example.
>
> I guess my original thought was, what is your long term intent with
> the move? And I was thinking you are probably heading to conditionally
> compiling. HOWEVER, now the scaredy-cat-me is thinking, shoot, that
> would add test config complexity and test misses. ie. Folks make a
> change in region_dax.c, don't test with CONFIG_CXL_PMEM enabled, and
> boom.
>
> So, I lean towards keeping them all (working) together, like you have.
>

fwiw i think this is the right take. It doesn't really cost us anything
to keep in, and probably prevents adding more Kconfig footguns.

~Gregory