Re: [PATCH v2 4/8] KVM: s390: Fix gmap_link()
From: Janosch Frank
Date: Tue Mar 24 2026 - 10:09:48 EST
On 3/20/26 17:15, Claudio Imbrenda wrote:
The slow path of the fault handler ultimately called gmap_link(), which
assumed the fault was a major fault, and blindly called dat_link().
In case of minor faults, things were not always handled properly; in
particular the prefix and vsie marker bits were ignored.
Move dat_link() into gmap.c, renaming it accordingly. Once moved, the
new _gmap_link() function will be able to correctly honour the prefix
and vsie markers.
Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
Fixes: 94fd9b16cc67 ("KVM: s390: KVM page table management functions: lifecycle management")
Fixes: a2c17f9270cc ("KVM: s390: New gmap code")
---
arch/s390/kvm/dat.c | 48 -------------------------------------
arch/s390/kvm/dat.h | 2 --
arch/s390/kvm/gmap.c | 56 ++++++++++++++++++++++++++++++++++++++++----
3 files changed, 52 insertions(+), 54 deletions(-)
Ugh, you moved it AND changed it.
Please don't do that if you want to have patches reviewed.
Or at least provide a diff between the changes.