Re: [PATCH] media: ir-i2c: add error handling for I2C send in get_key_adaptec()

From: Markus Elfring

Date: Tue Mar 24 2026 - 08:34:40 EST


> In get_key_adaptec(), a command byte (0x00) is sent to the IR chip via
> i2c_master_send() to initiate a key read. However, the return value of
> i2c_master_send() is not checked.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc5#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.0-rc5#n34



> If the send fails, return 0 to maintain the existing behavior (no key
> detected), but log the error for debugging purposes.

Will such a technical aspect be reconsidered in more detail?

Regards,
Markus