Re: [PATCH] staging: atomisp: pci: remove leading whitespace at the start of the line

From: Andy Shevchenko

Date: Tue Mar 24 2026 - 08:00:35 EST


On Tue, Mar 24, 2026 at 01:40:07PM +0530, Anushka Badhe wrote:
> Removed the whitespace at the start of the line to comply with
> linux kernel coding style.

Linux

...

> const hrt_address GP_TIMER_BASE =
> - (hrt_address)0x0000000000000600ULL;
> + (hrt_address)0x0000000000000600ULL;

Always think one or even two steps further. How does your patch add value?
For now it's just a warning of a tool or even no warning, just some whitespace
shuffling, which is usually the type of patches that are doomed to be ceased.

Compare to

const hrt_address GP_TIMER_BASE = (hrt_address)0x0000000000000600ULL;

which gives the same result + reduces number of LoC for free. This increases
the value of the change. Now, you can look at the rest of the code for the
indentation problems.

BUT, they are so-o-o-o LOW priority thing, that most likely will be simply
NAKed. Can you rather do a real patch instead, please?

--
With Best Regards,
Andy Shevchenko