Re: [PATCH 1/6] riscv: dts: spacemit: add LEDs for Milk-V Jupiter board

[Javier Martinez Canillas]

Aurelien Jarno <aurelien@xxxxxxxxxxx> writes:

Hello Aurelien,

> The Milk-V Jupiter board provides support for two LEDs through the front
> panel header. The "Power LED" indicates the system is running, and the
> "HDD LED" shows disk activity. Configure the corresponding LED triggers
> accordingly.
>
> Caveats:
> - The LEDs are driven through a 4.7k series resistor, making them
>   quite faint.
> - The disk activity trigger requires a storage controller on the M.2 or
>   PCIe interface. That said, it matches the purpose and the vendor
>   kernel.
>
> Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> ---

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat