RE: [PATCH v0 2/3] media: chips-media: wave5: Support CBP profile

[jackson . lee]

Hi Brandon

> The above code breaks setting GOP size for the AVC case. Any reason this
> shouldn't remain just an if else where the else sets both constraint flag
> and avc period?
>
> Best,
> Brandon
>

Good catch, Brandon.
You're right — the else-if structure breaks avc_idr_period for AVC.
I've changed it to a single else block that sets both constraint_set1_flag and avc_idr_period.
constraint_set1_flag defaults to 0 and is only set to 1 in s_ctrl when CONSTRAINED_BASELINE is selected, so this is safe for all AVC profiles.

Thanks
Jackson
[C&M]
IMPORTANT NOTICE

The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in some unexpected situation, please immediately notify the sender by replying email and then delete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, distribution, copying, or storage of this message or its attachments is strictly prohibited.