Re: [PATCH v6 13/13] ASoC: qcom: q6apm: Add support for early buffer mapping on DSP

[Srinivas Kandagatla]

On 3/20/26 3:44 PM, Mark Brown wrote:
> On Fri, Mar 20, 2026 at 02:49:18PM +0000, Srinivas Kandagatla wrote:
> 
>>  static int q6apm_dai_pcm_new(struct snd_soc_component *component, struct snd_soc_pcm_runtime *rtd)
>>  {
> 
>> +	if (pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream) {
>> +		substream = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
>> +		q6apm_dai_memory_map(component, substream, graph_id);
> 
> This doesn't assign ret...

True, should have collected the return value in ret.

--srini
> 
>> +		if (ret)
>> +			return ret;
> 
> ...which means this isn't doing the right thing.