Re: [PATCH v3 1/2] dt-bindings: can: mcp251xfd: add microchip,xstbyen property

[Conor Dooley]

On Mon, Mar 23, 2026 at 09:37:24PM +0100, Marc Kleine-Budde wrote:
> On 23.03.2026 19:30:00, Conor Dooley wrote:
> > > diff --git a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> > > index 2d13638ebc6a..28e494262cd9 100644
> > > --- a/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> > > +++ b/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml
> > > @@ -44,6 +44,14 @@ properties:
> > >        signals a pending RX interrupt.
> > >      maxItems: 1
> > >
> > > +  microchip,xstbyen:
> > > +    type: boolean
> > > +    description:
> > > +      If present, configure the INT0/GPIO0/XSTBY pin as transceiver standby
> > > +      control. The pin is driven low when the controller is active and high
> > > +      when it enters Sleep mode, allowing automatic standby control of an
> > > +      external CAN transceiver connected to this pin.
> >
> > What I don't understand from this patch is why a property for this is
> > required.
> > Why can't this mode be implied from the lack of rx-int-gpios or
> > interrupts?
> 
> The mcp251xfd has 2 GPIO pins. "rx-int-gpios" is for the other pin:
> INT1/GPIO1. Also by default I don't want the controller to drive a pin
> in a certain direction.

Oke.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature