Re: [PATCH v2 4/5] i3c: master: Fix error codes at send_ccc_cmd

[Jorge Marques]

On Wed, Mar 18, 2026 at 10:27:09AM -0400, Frank Li wrote:
> On Thu, Mar 12, 2026 at 05:38:07PM +0100, Jorge Marques wrote:
> > i3c_master_send_ccc_cmd_locked would propagate cmd->err (positive,
> 
> function name need (), i3c_dev_enable_ibi_locked(), check others.
> 
> > Mx codes) to the ret variable, cascading down multiple methods until
> > reaching methods that explicitly stated they would return 0 on success
> > or negative error code. For example, the call chain:
> >
> >   i3c_device_enable_ibi <- i3c_dev_enable_ibi_locked <-
> >   master->ops.enable_ibi <- i3c_master_enec_locked <-
> >   i3c_master_enec_disec_locked <- i3c_master_send_ccc_cmd_locked
> 
> why "<-" , look like should be "->" Or
> 
> 	i3c_device_enable_ibi()
> 	i3c_dev_enable_ibi_locked()
> 
> function need (), i3c_dev_enable_ibi_locked(),
> 
> >
> > Fix this by returning the ret value, callers can
> > still read the cmd->err value if ret is negative.
> 
> Can you wrap at 75 char.
> Fix this by returning the ret value, callers can still read the cmd->err
> value if ret is negative.
> 
> Frank

Ack all review comments.

Regards,
Jorge