Re: [PATCH v2] ASoC: soc-topology: fix __le32 conversion in printed values

From: Ben Dooks

Date: Mon Mar 23 2026 - 08:39:57 EST


On 19/03/2026 13:58, Mark Brown wrote:
On Wed, Mar 18, 2026 at 04:34:27PM +0000, Ben Dooks wrote:

@@ -1957,9 +1962,9 @@ static int soc_tplg_valid_header(struct soc_tplg *tplg,
if (soc_tplg_get_hdr_offset(tplg) + le32_to_cpu(hdr->payload_size) >= tplg->fw->size) {
dev_err(tplg->dev,
- "ASoC: invalid header of type %d at offset %ld payload_size %d\n",
+ "ASoC: invalid header of type %u at offset %ld payload_size %d\n",
le32_to_cpu(hdr->type), soc_tplg_get_hdr_offset(tplg),
- hdr->payload_size);
+ le32_to_cpu(hdr->payload_size));
return -EINVAL;
}

The format string for the type got converted but not that for the
payload size, both of which got le32_to_cpu() conversions.

Thanks, since there's been no-other reviews shall I fix and re-send v3?

--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html