Re: [PATCH 2/3] soc: qcom: ocmem: register reasons for probe deferrals

[Brian Masney]

On Mon, Mar 23, 2026 at 03:20:58AM +0200, Dmitry Baryshkov wrote:
> Instead of printing messages to the dmesg, let the message be recorded
> as a reason for the OCMEM client deferral.
> 
> Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/ocmem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c
> index dd46bb14b7be..d57baa9cfa03 100644
> --- a/drivers/soc/qcom/ocmem.c
> +++ b/drivers/soc/qcom/ocmem.c
> @@ -196,10 +196,10 @@ struct ocmem *of_get_ocmem(struct device *dev)
>  	}
>  
>  	pdev = of_find_device_by_node(devnode->parent);
> -	if (!pdev) {
> -		dev_err(dev, "Cannot find device node %s\n", devnode->name);
> -		return ERR_PTR(-EPROBE_DEFER);
> -	}
> +	if (!pdev)
> +		return ERR_PTR(dev_err_probe(dev, -EPROBE_DEFER,
> +					     "Cannot find device node %s\n",
> +					     devnode->name));

Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>

dev_err_probe() was introduced in 2020 (a787e5400a1c) and this driver
was added to the tree prior to that.