RE: [PATCH 3/3] iio: adc: ltc2309: add support for LTC2305

[Jones, Carlos jr]

> > -	ltc2309->chip_info = &ltc2309_chip_info;
> > +	ltc2309->chip_info = i2c_get_match_data(client);
> 
> Strictly speaking this change with the associated ID table changes should go in
> a separate patch.
> 
> ...
> 

Will do. Thanks.

> >  static const struct of_device_id ltc2309_of_match[] = {
> > -	{ .compatible = "lltc,ltc2309" },
> > +	{ .compatible = "lltc,ltc2309", .data = &ltc2309_chip_info },
> 
> 
> > +	{ .compatible = "lltc,ltc2305", .data = &ltc2305_chip_info },
> 
> Keep it ordered by the value of compatible string.
> 
> >  	{ }
> >  };
> 
> ...
> 
> >  static const struct i2c_device_id ltc2309_id[] = {
> > -	{ "ltc2309" },
> > +	{ "ltc2309", (kernel_ulong_t)&ltc2309_chip_info },
> > +	{ "ltc2305", (kernel_ulong_t)&ltc2305_chip_info },
> >  	{ }
> 
> In the similar way as above.
> 
> >  };
> 
> --
> With Best Regards,
> Andy Shevchenko
> 

Noted and thanks on the value order.