Re: [PATCH v5] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen

[Konrad Dybcio]

On 3/20/26 9:57 AM, Abel Vesa wrote:
> On 26-03-20 01:52:06, Dmitry Baryshkov wrote:
>> On Thu, Mar 19, 2026 at 11:11:18PM +0200, Abel Vesa wrote:
>>> On 26-03-19 21:49:07, Dmitry Baryshkov wrote:
>>>> On Thu, Mar 19, 2026 at 05:30:48PM +0200, Abel Vesa wrote:
>>>>> On CRD, the keyboard, trackpad and touchscreen are connected over I2C
>>>>> and all share a 3.3V regulator.
>>>>>
>>>>> So describe the regulator and each input device along with their
>>>>> pinctrl states.
>>>>>
>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>>>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
>>>>> ---
>>>>> Changes in v5:
>>>>> - Since this depends on Displat DT patchset and since that one
>>>>>   had to be respun in order to drop the non-merging phy patch
>>>>>   dependency, this one had to be respun as well so that the dependency
>>>>>   tree is correct.

[...]

>>>>> +	ts0_default: ts0-default-state {
>>>>> +		int-n-pins {
>>>>> +			pins = "gpio51";
>>>>
>>>> What was the sorting order here? I assume you had one.
>>>
>>> The way I see it, it should be based on state subnode name.
>>> Which currently it is.
>>>
>>> Do you suggest some other sorting order though ?
>>>
>>> Thanks for reviewing!
>>
>> Then ts0-default-state > pcie0
> 
> Oh, right. Will fix that.

+Krzysztof dts-coding-style should clarify this

(pin state subnode sorting, IMO it would make sense to have
both top-level and the child nodes sorted by the pinidx but I don't
really care that much)

Konrad