Re: [PATCH] ASoC: wm_adsp: select CONFIG_SND_SOC_WM_ADSP from all users

[Richard Fitzgerald]

On 20/03/2026 3:17 pm, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The addition of the kunit test made it possible to enable the WM_ADSP
> driver even when there are no users. However, an unintended side-effect
> was that it is also possible to turn it off when it is actually required,
> leading to build failures:

Sorry, I never thought of people intentionally disabling it just
because they can in a KUnit build.

> Reverse the logic to replace the ununual list of 'default y if ....' with
> the regular 'select' that do the same thing but prevent it from being
> disabled if that would break the build.

The unusual defaulting is because old kernels didn't support nested
selects. So when the machine driver selected the codec driver, any
selects in the codec driver would be ignored. The defaults were a
workaround.

> Fixes: bf2d44d07de7 ("ASoC: wm_adsp: Add kunit test for firmware file search")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>