Re: [PATCH] tty: atmel_serial: update outdated reference to atmel_tasklet_func()

[Richard GENOUD]

Le 21/03/2026 à 11:59, Kexin Sun a écrit :
> The modem-status comparison that used irq_status_prev was
> moved from atmel_tasklet_func() into atmel_handle_status() in
> commit 2c7af5ba65cf ("tty: serial: atmel: rework interrupt and
> wakeup handling"). atmel_tasklet_func() itself was later split
> into atmel_tasklet_rx_func() and atmel_tasklet_tx_func() in
> commit 00e8e65870cc ("tty/serial: atmel: split tx and rx
> paths").  Update the comment to reference
> atmel_handle_status(), which now performs the comparison.
Actually, it was in commit:
d033e82db9a5 ("tty/serial: at91: handle IRQ status more safely")
That irq_status prev/actual comparison was moved from 
atmel_tasklet_func() to atmel_handle_status().

And we don't need the rx/tx tasklet splitting history there.

IHMO, only the last sentence should suffice, but now that I've done the 
right commit research, you may add a reference to it :)

> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@xxxxxxxxxxxxxxxx>
> ---
>   drivers/tty/serial/atmel_serial.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 08dd8f887956..5d8c1cfc1c60 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -1927,7 +1927,7 @@ static int atmel_startup(struct uart_port *port)
>   		atmel_uart_writel(port, ATMEL_US_FMR, fmr);
>   	}
>   
> -	/* Save current CSR for comparison in atmel_tasklet_func() */
> +	/* Save current CSR for comparison in atmel_handle_status() */
>   	atmel_port->irq_status_prev = atmel_uart_readl(port, ATMEL_US_CSR);
>   
>   	/*

Thanks!