Re: [PATCH v4 04/12] scsi: ufs: core: Add support for TX Equalization

[Bean Huo]

On Fri, 2026-03-20 at 20:10 -0700, Can Guo wrote:
> MIPI Unipro3.0 introduced PA_TxEQGnSetting and PA_PreCodeEn attributes for
> TX Equalization and Pre-Coding. It is Host Software's responsibility to
> configure these attributes for both host and device before initiating
> Power Mode Change to High-Speed Gears.
> 
> MIPI Unipro3.0 also introduced TX Equalization Training (EQTR) to identify
> optimal TX Equalization settings for use by both Host's and Device's
> UniPro. TX EQTR shall be initiated from the most reliable High-Speed Gear
> (HS-G1) targeting High-Speed Gears (HS-G4 to HS-G6).
> 
> Implement TX Equalization configuration and TX EQTR procedure as defined
> in UFSHCI v5.0 specification. The TX EQTR procedure determines the optimal
> TX Equalization settings by iterating through all possible PreShoot and
> DeEmphasis combinations and selecting the best combinations for both Host
> and Device based on Figure of Merit (FOM) evaluation.
> 
> Signed-off-by: Can Guo <can.guo@xxxxxxxxxxxxxxxx>

Can, fix those two nits and add my Reviewed-by tag. Thanks!

Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>