Re: [PATCH v2 2/4] iio: adc: meson-saradc: add support for Meson S4

[Krzysztof Kozlowski]

On Mon, Mar 23, 2026 at 09:34:06AM +0800, Nick Xie wrote:
> Add support for the SARADC found on the Amlogic Meson S4 SoC.
> According to the documentation and current testing, it is fully
> compatible with the G12A parameter set, so we reuse
> `meson_sar_adc_g12a_data` for this new compatible string.
> 
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> Signed-off-by: Nick Xie <nick@xxxxxxxxxx>
> ---
>  drivers/iio/adc/meson_saradc.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index 47cd350498a0d..3ac48b7842c4f 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -1313,6 +1313,11 @@ static const struct meson_sar_adc_data meson_sar_adc_g12a_data = {
>  	.name = "meson-g12a-saradc",
>  };
>  
> +static const struct meson_sar_adc_data meson_sar_adc_s4_data = {
> +	.param = &meson_sar_adc_g12a_param,
> +	.name = "meson-s4-saradc",
> +};
> +
>  static const struct of_device_id meson_sar_adc_of_match[] = {
>  	{
>  		.compatible = "amlogic,meson8-saradc",
> @@ -1341,6 +1346,9 @@ static const struct of_device_id meson_sar_adc_of_match[] = {
>  	}, {
>  		.compatible = "amlogic,meson-g12a-saradc",
>  		.data = &meson_sar_adc_g12a_data,
> +	}, {
> +		.compatible = "amlogic,meson-s4-saradc",

The point of compatible devices is to not add such entries. Drop.

Best regards,
Krzysztof