Re: [PATCH 2/2] drm/bridge: th1520-dw-hdmi: Fix remove() callback

From: Dmitry Baryshkov

Date: Sun Mar 22 2026 - 23:54:15 EST


On Sat, Mar 21, 2026 at 03:12:11AM +0800, Felix Gu wrote:
> This driver stores struct th1520_hdmi * in platform drvdata, but
> th1520_dw_hdmi_remove() was reading it back as struct dw_hdmi *
> and passing it to dw_hdmi_remove(), so teardown runs on the wrong
> pointer.
>
> Retrieve struct th1520_hdmi * from platform drvdata and pass
> hdmi->dw_hdmi to dw_hdmi_remove().
>
> Fixes: 96f30ee0fb9d ("drm/bridge: add a driver for T-Head TH1520 HDMI controller")
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


--
With best wishes
Dmitry