Re: [PATCH RFC v2 3/9] iio: frequency: ad9910: add simple parallel port mode support

From: Jonathan Cameron

Date: Sun Mar 22 2026 - 12:53:24 EST


On Wed, 18 Mar 2026 20:28:34 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Wed, Mar 18, 2026 at 05:56:03PM +0000, Rodrigo Alencar via B4 Relay wrote:
>
> > Add parallel port channel with frequency scale, frequency offset, phase
> > offset, and amplitude offset extended attributes for configuring the
> > parallel data path.
>
> ...
>
> > + ret = iio_str_to_fixpoint(buf, MICRO / 10, &val, &val2);
>
> I think here we just use 100000 as it's in so many drivers de facto use.
> ideally this should be fixed on API level.

I wouldn't mind a series tidying this up, but if anyone proposes to do
that we'll want to not use the same naming so it is obvious if any
new drivers assume the old scaling.

I can't really remember why we ended up with the odd interface :(

Jonathan