Re: [PATCH v4 04/12] scsi: ufs: core: Add support for TX Equalization

[Bean Huo]

On Sun, 2026-03-22 at 10:48 +0100, Bean Huo wrote:
> > +                       dev_err(hba->dev, "Failed to train TX Equalization
> > for
> > HS-G%u, Rate-%s: %d\n",
> > +                               gear, ufs_hs_rate_to_str(rate), ret);
> > +                       return ret;
> > +               }
> > +
> > +               /* Mark TX Equalization settings as valid */
> > +               params->is_valid = true;
> > +               params->is_applied = false;
> 
> after eqtr completes here, the trained settings are only kept in memory. UFS
> 5.0
> introduced qTxEQGnSettings and wTxEQGnSettingsExt as persistent device
> attributes for storing optimal TX EQ results across power cycles. should we
> write back to these attributes after training, and read them on next boot to
> skip EQTR if valid settings already exist? That would save the training
> overhead
> on every boot?


I saw your next section properly positions qTxEQGnSettings/wTxEQGnSettingsExt
persistent storage as a follow-up series in cover-letter, you can ignore this,
let's address it next following patch.

Kind regards,
Bean
 
> 
> Kind regards,
> Bean