Re: [PATCH v6 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI

[Guenter Roeck]

Hi,

On 3/20/26 23:51, Oleksij Rempel wrote:
> This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> Interface (MSDI) via the MFD framework.
>
> Architecture overview:
> * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
>    linear irq_domain. Harvests status bits from SPI MISO MSB.
> * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
>    the MFD domain.
> * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
>    fault alarms.
> * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
>    temperature, VBATP) to an external ADC.
Sashiko has a number of concerns with this series. See

https://sashiko.dev/#/patchset/20260321065146.3918882-1-o.rempel%40pengutronix.de

for details. I did not check the non-hwmon code, but the concerns raised with
the hwmon patch seem real. Please address.

Thanks,
Guenter