Re: [PATCH v2 1/2] dt-bindings: clock: loongson,ls2k: add ls2k1000 compatible

[Yao Zi]

On Sun, Mar 22, 2026 at 04:19:14PM +0800, wjjsn wrote:
> Add a SoC-specific "loongson,ls2k1000-clk" compatible.
> Retain the existing "loongson,ls2k-clk" as a deprecated fallback
> for backward compatibility.
> 
> Signed-off-by: wjjsn <wjjsn@xxxxxx>
> ---
>  .../devicetree/bindings/clock/loongson,ls2k-clk.yaml        | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml b/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml
> index c07ad1f85857..4d70bc4e7a13 100644
> --- a/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml
> @@ -13,12 +13,16 @@ description: |
>    Loongson-2 SoC clock control module is an integrated clock controller, which
>    generates and supplies to all modules.
>  
> +  The "loongson,ls2k1000-clk" string should be used for Loongson-2K1000.
> +  The "loongson,ls2k-clk" string is kept as a fallback for backward compatibility for Loongson-2K1000.
> +
>  properties:
>    compatible:
>      enum:
>        - loongson,ls2k0300-clk
>        - loongson,ls2k0500-clk
> -      - loongson,ls2k-clk  # This is for Loongson-2K1000
> +      - loongson,ls2k-clk
> +      - loongson,ls2k1000-clk

If you want to deprecate loongson,ls2k-clk, you should probably mark
it as "deprecated: true", instead of describing such situation in human
language.

I don't have a strong opinion on the change, but I don't think it
improves the situation much. We still need to document the historical
compatible in bindings and support it in driver, the only thing gets
improved is a slightly more clear compatible name in devicetree.

However, even if someone is confused by the current compatible, they
could have a look in the binding and get an explanation quickly.

Regards,
Yao Zi

>        - loongson,ls2k2000-clk
>  
>    reg:
> -- 
> 2.43.0
> 
>