Re: [PATCH v6 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor

[David Lechner]

On 3/21/26 6:40 PM, Sirat wrote:
> On Sat, Mar 21, 2026 at 11:22 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>>
>> On Fri, 20 Mar 2026 01:07:14 +0600
>> Siratul Islam <email@xxxxxxxx> wrote:
>>
>>> Add support for the STMicroelectronics VL53L1X Time-of-Flight
>>> ranging sensor with I2C interface.
>>>
>>> Signed-off-by: Siratul Islam <email@xxxxxxxx>
>> Hi Siratul
>>
>> Just a few minor things seeing as you are going to v7 anyway.
>> If you weren't I'd have applied some or maybe all of these as tweaks
>> whilst picking the driver up.
>>
> No problem at all.
>>
>>> diff --git a/drivers/iio/proximity/vl53l1x-i2c.c b/drivers/iio/proximity/vl53l1x-i2c.c
>>> new file mode 100644
>>> index 000000000000..771598b92e04
>>> --- /dev/null
>>> +++ b/drivers/iio/proximity/vl53l1x-i2c.c
>>> @@ -0,0 +1,820 @@
>>
> ---
>>> +     /*
>>> +      * vdd-supply is required in the DT binding but we
>>> +      * continue if it is missing to support older DTs.
>>
>> Given the driver does nothing different for an auto provided fake regulator
>> and one from DT, I'm not seeing the comment as particularly useful.
>>
>> Drop it.
>>
> Considering there is zero difference between the fake and real regulators
> in terms of functionality of this driver, should we just drop the hard
> requirement in the binding?

No, bindings should not depend on driver implementation.

>>
> 
> Thanks,
> Sirat