[PATCH 1/3] Input: adafruit-seesaw - switch to using dev_err_probe()
From: charles . embedded
Date: Sat Mar 21 2026 - 16:26:44 EST
From: Charles Dias <charlesdias.cd@xxxxxxxxxxx>
Use dev_err_probe() instead of dev_err() in seesaw_probe function
to improve error handling.
Signed-off-by: Charles Dias <charlesdias.cd@xxxxxxxxxxx>
---
drivers/input/joystick/adafruit-seesaw.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/input/joystick/adafruit-seesaw.c b/drivers/input/joystick/adafruit-seesaw.c
index c248c15b849d..177b42446e9b 100644
--- a/drivers/input/joystick/adafruit-seesaw.c
+++ b/drivers/input/joystick/adafruit-seesaw.c
@@ -277,17 +277,12 @@ static int seesaw_probe(struct i2c_client *client)
SEESAW_JOYSTICK_FUZZ, SEESAW_JOYSTICK_FLAT);
err = sparse_keymap_setup(seesaw->input_dev, seesaw_buttons_new, NULL);
- if (err) {
- dev_err(&client->dev,
- "failed to set up input device keymap: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(&client->dev, err, "failed to set up input device keymap\n");
err = input_setup_polling(seesaw->input_dev, seesaw_poll);
- if (err) {
- dev_err(&client->dev, "failed to set up polling: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(&client->dev, err, "failed to set up polling\n");
input_set_poll_interval(seesaw->input_dev,
SEESAW_GAMEPAD_POLL_INTERVAL_MS);
@@ -295,10 +290,8 @@ static int seesaw_probe(struct i2c_client *client)
input_set_min_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_MIN);
err = input_register_device(seesaw->input_dev);
- if (err) {
- dev_err(&client->dev, "failed to register joystick: %d\n", err);
- return err;
- }
+ if (err)
+ return dev_err_probe(&client->dev, err, "failed to register joystick\n");
return 0;
}