Re: [PATCH] iio: adc: ad7280a: replace mutex_lock() with guard(mutex)

[Jonathan Cameron]

On Thu, 19 Mar 2026 15:46:15 -0300
Matheus Giarola <matheustpgiarola@xxxxxxxxx> wrote:

> Use guard(mutex) instead of mutex_lock()/mutex_unlock(),
> ensuring the mutex is released automatically when leaving
> the function scope. The change improves error handling and
> avoids issues such as missing unlocks. It also simplifies the
> code by removing 'err_unlock' label and several mutex_unlock()
> calls.
> 
> Signed-off-by: Matheus Giarola <matheusgiarola@xxxxxx>
Hi Matheus.


> @@ -885,13 +875,12 @@ static int ad7280_read_raw(struct iio_dev *indio_dev,
>  
>  	switch (m) {
>  	case IIO_CHAN_INFO_RAW:
> -		mutex_lock(&st->lock);
> +		guard(mutex)(&st->lock);

Scope missing...

Thanks,

Jonathan

>  		if (chan->address == AD7280A_ALL_CELLS)
>  			ret = ad7280_read_all_channels(st, st->scan_cnt, NULL);
>  		else
>  			ret = ad7280_read_channel(st, chan->address >> 8,
>  						  chan->address & 0xFF);
> -		mutex_unlock(&st->lock);
>  
>  		if (ret < 0)
>  			return ret;