Re: drivers/uio/uio_pci_generic_sva.c:140 probe() warn: passing devm_ allocated variable to kfree. 'udev'

From: Dan Carpenter

Date: Sat Mar 21 2026 - 06:22:53 EST


On Sat, Mar 21, 2026 at 05:51:15PM +0800, yaxing guo wrote:
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 135 pci_set_drvdata(pdev, udev);
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 136
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 137 return 0;
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 138
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 139 out_free:
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 @140 kfree(udev);
> >
> > So this is a double free.
> >
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 141 out_disable:
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 142 pci_disable_device(pdev);
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 143
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 144 return ret;
> > 3397c3cd859a2c Yaxing Guo 2025-09-26 145 }
> >
>
> Hi Dan,
> The double-free issue has been addressed by Shuangshuo Li, who has already
> submitted a fix patch:
>
> https://lore.kernel.org/lkml/20260226153250.18079-1-lgs201920130244@xxxxxxxxx/
>

Okay. Good. I actually reported this bug to you last year in
November.

https://lore.kernel.org/all/202511280815.WV9iCJZb-lkp@xxxxxxxxx/

regards,
dan carpenter