Re: [PATCH v4 1/2] dt-bindings: embedded-controller: Add synology,microp device
From: Krzysztof Kozlowski
Date: Sat Mar 21 2026 - 06:22:04 EST
On Fri, Mar 20, 2026 at 11:09:53PM +0100, Markus Probst wrote:
> +
> +examples:
> + - |
> + #include <dt-bindings/leds/common.h>
> +
> + embedded-controller {
> + compatible = "synology,microp";
> +
> + power-led {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_POWER;
> + };
> +
> + status-led {
> + color = <LED_COLOR_ID_MULTI>;
> + function = LED_FUNCTION_STATUS;
> + };
Where are other leds? Binding mentions 4. Does that mean that they
differ on each device? The EC is tied to specific model, so that would
be surprising. And if they do not differ, what is exactly the point of
describing the LEDs in DT?
> + };
>
> --
> 2.52.0
>