Re: [PATCH 3/6] mm: change to return bool for pmdp_test_and_clear_young()

From: IBM

Date: Sat Mar 21 2026 - 01:26:22 EST


Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> writes:

> Callers use pmdp_test_and_clear_young() to clear the young flag and check
> whether it was set for this PMD entry. Change the return type to bool to
> make the intention clearer.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> ---
> arch/arm64/include/asm/pgtable.h | 6 +++---
> arch/powerpc/include/asm/book3s/64/pgtable.h | 10 +++++-----
> arch/powerpc/mm/book3s64/pgtable.c | 4 ++--
> arch/riscv/include/asm/pgtable.h | 2 +-
> arch/s390/include/asm/pgtable.h | 4 ++--
> arch/x86/include/asm/pgtable.h | 4 ++--
> arch/x86/mm/pgtable.c | 6 +++---
> include/linux/pgtable.h | 19 +++++++++----------
> 8 files changed, 27 insertions(+), 28 deletions(-)
>

LGTM. Please feel free to add:
(assuming you will anyway kill the unwanted externs)

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx>