Re: [PATCH v4 4/5] nfs: refactor nfs_errorf macros and remove unused ones

From: Andy Shevchenko

Date: Fri Mar 20 2026 - 15:23:05 EST


On Sat, Mar 21, 2026 at 02:09:54AM +0800, Sean Chang wrote:
> refactor nfs_errorf() and nfs_ferrorf() to the standard do-while(0)
> pattern for safer macro expansion and kernel style compliance.

> additionally, remove nfs_warnf() and nfs_fwarnf() as git grep

`git grep`

> confirms they have no callers in the current tree.

You can also add that they were never actually used from the day of
introduction by the commit ce8866f0913f ("NFS: Attach supplementary error
information to fs_context.").

--
With Best Regards,
Andy Shevchenko