Re: [PATCH v0 1/3] media: chips-media: wave5: Add Support for Background Detection

[Nicolas Dufresne]

Le vendredi 20 mars 2026 à 01:34 +0000, jackson.lee a écrit :
> Hi Nicolas
> > > 
[...]

> > > 
> > 
> > The hard question, last parameter here is def, so I read this is disabled
> > by default. What's the side effect of having this enabled by default ? Did
> > you already considered that option ?
> > 
> 
> Background detection is disabled by default because not all use cases benefit
> from this feature.
> When enabled, detected background regions are encoded with fewer bits or skip
> mode,
> which reduces bitrate but may not be desirable in every scenario.
> We chose to let the user explicitly opt-in rather than enable it by default.

Ack

> 
> Thanks for your review.
> Jackson

Attachment: signature.asc
Description: This is a digitally signed message part